Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift swap request Slack follow-ups #2798

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Shift swap request Slack follow-ups #2798

merged 7 commits into from
Aug 16, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Aug 15, 2023

What this PR does

Add Slack follow-up messages for shift swap requests:

Screenshot 2023-08-15 at 20 19 49

Which issue(s) this PR fixes

#2679

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 15, 2023
@vstpme vstpme marked this pull request as ready for review August 15, 2023 19:30
@vstpme vstpme requested a review from a team August 15, 2023 19:30
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor nit comment.

engine/settings/prod_without_db.py Show resolved Hide resolved
engine/apps/schedules/tasks/shift_swaps/slack_followups.py Outdated Show resolved Hide resolved
@vstpme vstpme added this pull request to the merge queue Aug 16, 2023
Merged via the queue into dev with commit 93b3521 Aug 16, 2023
@vstpme vstpme deleted the vadimkerr/ssr-followups branch August 16, 2023 08:42
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2023
# What this PR does

Adds SSR push notification follow-ups (similar to
#2798)

## Which issue(s) this PR fixes

#2679

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants