Move alerts inside PageNav #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cf6582 to
0fbfcb0
Compare
maskin25
reviewed
Jan 6, 2023
|
|
||
| return ( | ||
| <RealPluginPage {...props}> | ||
| {/* Render alerts at the top */} | ||
| {props.renderAlertsFn && props.renderAlertsFn()} |
There was a problem hiding this comment.
move logic to within upcoming PR's
maskin25
approved these changes
Jan 6, 2023
This was referenced Jan 10, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix for #904 - TopNav: Move Alerts inside PluginPage
Fix for #908 - Horizontal menu scrolling fix for tabs
There's also a few styling tweaks to be more in match with Grafana core styles.