Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopNav: Move alerts and other content into the page #904

Closed
torkelo opened this issue Nov 24, 2022 · 3 comments
Closed

TopNav: Move alerts and other content into the page #904

torkelo opened this issue Nov 24, 2022 · 3 comments
Assignees
@teodosii @raphael-batte
Labels
bug Something isn't working involved:UX

Comments

@torkelo
Copy link
Member

torkelo commented Nov 24, 2022

Please try to move alert and any content into the inside of the PluginPage (nothing should be placed outside it)

Screenshot 2022-11-24 at 16 20 58
@torkelo
Copy link
Member Author

torkelo commented Nov 24, 2022

Also there is another bug, there is no page padding when using the old nav, looks like oncall is modifying the global pages styles and breaking the style system here:

Screenshot 2022-11-24 at 16 28 57

@torkelo torkelo added bug Something isn't working involved:UX labels Nov 24, 2022
@teodosii teodosii mentioned this issue Dec 21, 2022
Closed
@teodosii
Copy link
Member

From Raphael - https://www.figma.com/file/sJ4RvHvnUq6AZAiHYYiB5j/Grafana-OnCall?node-id=5310%3A109664&t=h3qXWrpGqXkNfNC9-1

@teodosii teodosii mentioned this issue Dec 22, 2022
Merged
teodosii added a commit that referenced this issue Jan 6, 2023
@teodosii
Move alerts inside PageNav (#1040)
d8dcb67 
# What this PR does

Fix for #904 - TopNav: Move Alerts inside PluginPage
Fix for #908 - Horizontal menu scrolling fix for tabs

There's also a few styling tweaks to be more in match with Grafana core
styles.
@teodosii
Copy link
Member

Also fixed #1040 not yet released

brojd pushed a commit that referenced this issue Sep 18, 2024
@teodosii
Move alerts inside PageNav (#1040)
c8082db 
# What this PR does

Fix for #904 - TopNav: Move Alerts inside PluginPage
Fix for #908 - Horizontal menu scrolling fix for tabs

There's also a few styling tweaks to be more in match with Grafana core
styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

@raphael-batte raphael-batte

Labels
bug Something isn't working involved:UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@torkelo @teodosii @raphael-batte