Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import blockscopy too and rename it to copyblocks #3264

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Import blockscopy too and rename it to copyblocks #3264

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1f11ff3
Import blockscopy too and rename it to copyblocks
pracucci Oct 20, 2022
41b9cc8
Update tools/copyblocks/README.md
pracucci Oct 20, 2022
c465570
Improved error check
pracucci Oct 20, 2022
86906d3
go mod tidy
pracucci Oct 20, 2022
1d36683
Apply suggestions from code review
pracucci Oct 20, 2022
d10f2d6
Address more copy feedback
pracucci Oct 20, 2022
0f844ac
Add missing license header
pracucci Oct 20, 2022
989c3d6
Apply suggestions from code review
pracucci Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@

### Tools

* [FEATURE] Add `copyblocks` tool, to copy Mimir blocks between two GCS buckets. #3263
* [ENHANCEMENT] Mimir rules GitHub action: Added the ability to change default value of `label` when running `prepare` command. #3236

## 2.4.0-rc.1
Expand Down
9 changes: 9 additions & 0 deletions tools/copyblocks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Copy blocks

This program can copy Mimir blocks between two GCS buckets. It is GCS specific and uses special calls to copy
files between buckets directly, without download to a local system first.
Copy link
Contributor

@osg-grafana osg-grafana Oct 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
files between buckets directly, without download to a local system first.
files between buckets directly, without first downloading them to a local system.

Is it accurate or inaccurate to include the word "first" in this phrase? With it, a download might happen; without it, a download does not happen.


copyblocks can run in one-time mode, or as a service and do regular copies.

It can be configured with minimum block time range to avoid copying of blocks that are too small.
It can also be configured with list of users to copy, or avoid copying blocks for.
Loading