Import blockscopy too and rename it to copyblocks #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Oct 20, 2022
|
We should perhaps change the original repo to remove the tool, or to link to this mimir-specific version. |
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Definitely, I will. |
|
pstibrany
approved these changes
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
| # Copy blocks | ||
|
|
||
| This program can copy Mimir blocks between two GCS buckets. It is GCS specific and uses special calls to copy | ||
| files between buckets directly, without download to a local system first. |
There was a problem hiding this comment.
Suggested change
| files between buckets directly, without download to a local system first. | |
| files between buckets directly, without first downloading them to a local system. |
Is it accurate or inaccurate to include the word "first" in this phrase? With it, a download might happen; without it, a download does not happen.
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
reviewed
Oct 20, 2022
osg-grafana
approved these changes
Oct 20, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
3 tasks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We have a tool https://github.com/grafana/cortex-tools/tree/main/cmd/blockscopy to copy blocks between GCS bucket (it's GCS specific). I need to add more features to it (e.g. copy no-compact markers too), but first I would like to move it Mimir repo along with other tools. I've also rename it to
copyblocksto keep consistency with the other tools we have (listblocks,markblocks).If this PR will be accepted, I will open an issue to add support for all storage backends in this tool too and write its doc.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]