Rewrite subqueries that have the same range and resolution (#10445) #10459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
commented
Jan 16, 2025
| @@ -28,6 +28,8 @@ | |||
| * [BUGFIX] MQE: Fix deriv with histograms #10383 | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported Media Type instead of 200 Success for Remote Write 2.0 until we support it. #10423 | |||
There was a problem hiding this comment.
Might have messed up the cherry-pick here, but it's the changelog so it's harmless.
tacole02
approved these changes
Jan 16, 2025
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
From feedback #10459 (comment) Related #10445 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
4 tasks
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
* docs: Fix help text for query-frontend.prom2-range-compat flag From feedback #10459 (comment) Related #10445 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed).
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
(cherry picked from commit b812677)