Rewrite subqueries that have the same range and resolution #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7019fd3 to
5c1f532
Compare
|
💻 Deploy preview deleted. |
5c1f532 to
92e3988
Compare
chencs
approved these changes
Jan 15, 2025
Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed).
44d09d5 to
7c4e255
Compare
ywwg
approved these changes
Jan 15, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10445-to-r325 origin/r325
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b812677266850268b4b00dd689a3baedb13a87b2
# Push it to GitHub
git push --set-upstream origin backport-10445-to-r325
git switch main
# Remove the local backport branch
git branch -D backport-10445-to-r325Then, create a pull request where the |
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
* Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
…10459) * Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
From feedback #10459 (comment) Related #10445 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
4 tasks
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
* Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
…10463) * Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 16, 2025
* docs: Fix help text for query-frontend.prom2-range-compat flag From feedback #10459 (comment) Related #10445 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Jan 17, 2025
* Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 17, 2025
…10472) * Rewrite subqueries that have the same range and resolution Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed). * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit b812677)
56quarters
added a commit
that referenced
this pull request
Jan 22, 2025
Follow up to #10445, add a metric when queries are rewritten for compatibility with Prometheus 3 range selector semantics. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
4 tasks
56quarters
added a commit
that referenced
this pull request
Jan 22, 2025
Follow up to #10445, add a metric when queries are rewritten for compatibility with Prometheus 3 range selector semantics. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Jan 23, 2025
* Add visibility when subqueries are rewritten Follow up to #10445, add a metric when queries are rewritten for compatibility with Prometheus 3 range selector semantics. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Skip TestSampleTracker_Concurrency since it is not reliable Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix queries that have the same range and resolution since this will only return a single point when using Prometheus 3 selectors, left open and right closed (compared to Prometheus 2 left closed and right closed).
Which issue(s) this PR fixes or relates to
Internal incident
Notes for reviewers
These names were the first things I thought of, please feel free to suggest better ones!
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.