Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging and metrics handler middlewares #1117

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Logging and metrics handler middlewares #1117

merged 7 commits into from
Oct 17, 2024

Conversation

marefr
Copy link
Contributor

@marefr marefr commented Oct 16, 2024 •
edited
Loading

What this PR does / why we need it:
Adds logging and metrics handler middlewares that (for now) can be used from Grafana.

Which issue(s) this PR fixes:
Ref #1101

Special notes for your reviewer:

@marefr marefr self-assigned this Oct 16, 2024
marefr
marefr commented Oct 16, 2024
View reviewed changes
@marefr marefr changed the title Convert common adapter logic to middlewares Logging and metrics handler middlewares Oct 17, 2024
@marefr marefr marked this pull request as ready for review October 17, 2024 13:01
@marefr marefr requested a review from a team as a code owner October 17, 2024 13:01
@marefr marefr requested review from wbrowne, andresmgot and xnyo and removed request for a team October 17, 2024 13:01
@marefr marefr mentioned this pull request Oct 17, 2024
Merged
wbrowne
wbrowne approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr merged commit 1c86e1e into main Oct 17, 2024
3 checks passed
@marefr marefr deleted the autoinstrumentation_poc branch October 17, 2024 13:57
@marefr marefr mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrowne wbrowne wbrowne approved these changes

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@xnyo xnyo Awaiting requested review from xnyo xnyo is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@marefr marefr

Labels
None yet
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marefr @wbrowne