Error source handler middleware #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
309bfc7 to
b95ac03
Compare
3 tasks
marefr
commented
Oct 8, 2024
andresmgot
approved these changes
Oct 9, 2024
ivanahuckova
approved these changes
Oct 9, 2024
| require.Equal(t, tc.expErrorSource, ss) | ||
| }) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("QueryData response without valid error source error should set error source", func(t *testing.T) { |
s4kh
reviewed
Oct 10, 2024
wbrowne
approved these changes
Oct 14, 2024
This was referenced Oct 16, 2024
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error source handler middleware that can be used both within the SDK and in Grafana.
Still left to share the error source handler middleware logic with the existing auto instrumentation in https://github.com/grafana/grafana-plugin-sdk-go/blob/main/backend/adapter_utils.go and https://github.com/grafana/grafana-plugin-sdk-go/blob/main/backend/data_adapter.go.
Ref #1082