Rename Alertmanager -> GrafanaAlertmanager and remove KVStore
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fanaAlertmanager A couple of things: - Renames `Alertmanager` to `GrafanaAlertmanager` - Introduces `GrafanaAlertmanagerConfig` - Removes the dependency on grafana's KVStore Found a bug in the process that I've filled as #3
JohnnyQQQQ
approved these changes
Jul 14, 2022
| @@ -192,15 +194,15 @@ func newAlertmanager(ctx context.Context, orgID int64, cfg *setting.Cfg, store A | |||
|
|
|||
| am.wg.Add(1) | |||
| go func() { | |||
| am.silences.Maintenance(silenceMaintenanceInterval, silencesFilePath, am.stopc, func() (int64, error) { | |||
| am.silences.Maintenance(config.Silences.MaintenanceFrequency(), config.Silences.Filepath(), am.stopc, func() (int64, error) { | |||
| // Delete silences older than the retention period. | |||
| if _, err := am.silences.GC(); err != nil { | |||
| am.logger.Error("silence garbage collection", "err", err) | |||
| // Don't return here - we need to snapshot our state first. | |||
| } | |||
|
|
|||
| // Snapshot our silences to the Grafana KV store | |||
There was a problem hiding this comment.
I think the comment might need an update too as it's not the Grafana KV store exclusively.
Closed
yuri-tceretian
added a commit
that referenced
this pull request
Jan 27, 2023
^ This is the 1st commit message: refactor notifier package move services to deciated packages split configurations and implementations ^ The commit message #2 will be skipped: ^ move factory from Grafana ^ The commit message #3 will be skipped: ^ rename settings to config ^ The commit message #4 will be skipped: ^ reaname TemplateForTests to FroTests to appease linter ^ The commit message #5 will be skipped: ^ lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things:
AlertmanagertoGrafanaAlertmanagerGrafanaAlertmanagerConfigFound a bug in the process that I've filled as #3