Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No calling GC on the notification log as part of the Grafana Alertmanager #3

Closed
gotjosh opened this issue Jul 14, 2022 · 1 comment · Fixed by #44
Closed

No calling GC on the notification log as part of the Grafana Alertmanager #3

gotjosh opened this issue Jul 14, 2022 · 1 comment · Fixed by #44

Comments

@gotjosh
Copy link
Collaborator

gotjosh commented Jul 14, 2022

https://github.com/grafana/alerting/blob/main/alerting/grafana_alertmanager.go#L171

We're not cleaning up old entries unless we do.
gotjosh added a commit that referenced this issue Jul 14, 2022
@gotjosh
Remove dependency on Grafana's KVstore and rename Alertmanager -> Gra…
263c6d4 
…fanaAlertmanager

A couple of things:

- Renames `Alertmanager` to `GrafanaAlertmanager`
- Introduces `GrafanaAlertmanagerConfig`
- Removes the dependency on grafana's KVStore

Found a bug in the process that I've filled as #3
@gotjosh gotjosh mentioned this issue Jul 14, 2022
Merged
gotjosh added a commit that referenced this issue Jul 14, 2022
@gotjosh
Remove dependency on Grafana's KVstore and rename Alertmanager -> Gra…
47df9c0 
…fanaAlertmanager

A couple of things:

- Renames `Alertmanager` to `GrafanaAlertmanager`
- Introduces `GrafanaAlertmanagerConfig`
- Removes the dependency on grafana's KVStore

Found a bug in the process that I've filled as #3
@gotjosh
Copy link
Collaborator Author

gotjosh commented Jan 18, 2023

With prometheus/alertmanager#3220 it should now be possible to fix this bug and the current panic when using the tip of master.

@gotjosh gotjosh mentioned this issue Jan 19, 2023
Merged
yuri-tceretian added a commit that referenced this issue Jan 27, 2023
@yuri-tceretian
^ This is a combination of 5 commits.
06b42ff 
^ This is the 1st commit message:

refactor notifier package

move services to deciated packages
split configurations and implementations

^ The commit message #2 will be skipped:

^ move factory from Grafana

^ The commit message #3 will be skipped:

^ rename settings to config

^ The commit message #4 will be skipped:

^ reaname TemplateForTests to FroTests to appease linter

^ The commit message #5 will be skipped:

^ lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Alertmanager via grafana/alertmanager-prometheus to the latest main grafana/alerting
1 participant
@gotjosh