Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI workflows to use 23.1 #362

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Sep 6, 2023

Fix CI for 23.1 branch.

This patch does the following (in separate commits):

Graal master branch is currently not buildable and is, thus,
not helpful for CI runs. In order to avoid breakages I propose to move
to 23.1 temporarily.
This test depends on polyglot.jar which isn't part of
Mandrel anymore.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 6, 2023
@jerboaa jerboaa requested a review from zakkak September 6, 2023 13:56
@zakkak
Copy link
Collaborator

zakkak commented Sep 6, 2023

The 2 step build fails with:

AttributeError: 'Namespace' object has no attribute 'generate_javadoc'

Could it be that we are using the wrong mx version? i.e. mx master might not be compatible with 23.1

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

The 2 step build fails with:

AttributeError: 'Namespace' object has no attribute 'generate_javadoc'

Could it be that we are using the wrong mx version? i.e. mx master might not be compatible with 23.1

Possibly. It passed yesterday, though (with mx revision c86b9e88a23ec263d9f19b754b29d30dd18272da). See:
https://github.com/graalvm/mandrel-packaging/actions/runs/6087706591

Let me try with it.

@zakkak
Copy link
Collaborator

zakkak commented Sep 6, 2023

I suggest pinning the mx version to 6.42.0 (or possibly get it from common.json, although I recall having some difficulty in doing so), see https://github.com/graalvm/mandrel/blob/mandrel/23.1/common.json#L7

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

I suggest pinning the mx version to 6.42.0 (or possibly get it from common.json, although I recall having some difficulty in doing so), see https://github.com/graalvm/mandrel/blob/mandrel/23.1/common.json#L7

Sure that works too. I'll let the run with 6.45.0 complete and then possibly tune it down to 6.42.0

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

@zakkak CI is happy. Do you want me to use 6.42.0 instead or is 6.45.0 good enough?

@zakkak
Copy link
Collaborator

zakkak commented Sep 6, 2023

I am OK with either.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

OK, merging as is then. Thanks!

@jerboaa jerboaa merged commit 8d91226 into graalvm:23.1 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants