-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CI workflows to use 23.1 #362
Conversation
Graal master branch is currently not buildable and is, thus, not helpful for CI runs. In order to avoid breakages I propose to move to 23.1 temporarily.
This test depends on polyglot.jar which isn't part of Mandrel anymore.
The 2 step build fails with:
Could it be that we are using the wrong mx version? i.e. mx |
Possibly. It passed yesterday, though (with Let me try with it. |
I suggest pinning the mx version to 6.42.0 (or possibly get it from common.json, although I recall having some difficulty in doing so), see https://github.com/graalvm/mandrel/blob/mandrel/23.1/common.json#L7 |
Sure that works too. I'll let the run with |
@zakkak CI is happy. Do you want me to use |
I am OK with either. |
OK, merging as is then. Thanks! |
Fix CI for 23.1 branch.
This patch does the following (in separate commits):
polyglot.jar
currently not part of Mandrel 23.1native-image --version
after the launcher macro build since we can catch bugs that way like GraalVM 24.0+ breaks the native-image driver (in native mode) mandrel#556