Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily move to building 23.1 #361

Closed
wants to merge 4 commits into from
Closed

Temporarily move to building 23.1 #361

wants to merge 4 commits into from

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Sep 5, 2023 •
edited
Loading

Graal master branch is currently not buildable (in the Mandrel config) and is, thus, not helpful for CI runs. In order to avoid breakages I propose to move to 23.1 temporarily.

This patch also does the following (in separate commits):

@jerboaa jerboaa requested a review from zakkak September 5, 2023 14:46
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 5, 2023
@jerboaa jerboaa changed the title Temporarilty move to building 23.1 Temporarily move to building 23.1 Sep 5, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 5, 2023

Switching to JDK 21 will be needed too...

@jerboaa
Temporarily move to building 23.1
a7f770d 
Graal master branch is currently not buildable and is, thus,
not helpful for CI runs. In order to avoid breakages I propose to move
to 23.1 temporarily.
@jerboaa
Use JDK 21 for CI builds
219562d
@jerboaa
Disable Version test
f8b103b 
This test depends on polyglot.jar which isn't part of
Mandrel anymore.
@jerboaa
Run native-image --version after the launcher macro build
539cada
@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 5, 2023

a7f770d should be easily revertable once we have 24.0/master working again.

@zakkak
Copy link
Collaborator

zakkak commented Sep 6, 2023

Graal master branch is currently not buildable (in the Mandrel config) and is, thus, not helpful for CI runs. In order to avoid breakages I propose to move to 23.1 temporarily.

I am not sure how useful that is. mandrel-packaging's master branch is meant to build mandrel's oracle/master branch, if that's broken then the CI should fail as it does.

For building/testing 23.1 builds we should use https://github.com/graalvm/mandrel-packaging/tree/23.1
IMO if we need a change for 23.1 that we probably want in master as well we should open a PR against 23.1 and if all looks good open the same PR against master and merge it despite the CI failing on master.

Other than that, it looks good to me.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

OK. Replaced by #363

@jerboaa jerboaa closed this Sep 6, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 6, 2023

For building/testing 23.1 builds we should use https://github.com/graalvm/mandrel-packaging/tree/23.1
IMO if we need a change for 23.1 that we probably want in master as well we should open a PR against 23.1

PR against 23.1 is here:
#362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak Awaiting requested review from zakkak

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerboaa @zakkak