Invalidate cache after generating new GPG key #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gopasspw#1693 RELEASE_NOTES=[BUGFIX] Invalidate GPG key list after generation Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
AnomalRoil
approved these changes
Jan 12, 2021
| @@ -203,7 +203,6 @@ func (s *Action) InitOnboarding(c *cli.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| ctx = out.AddPrefix(ctx, "[init] ") | |||
There was a problem hiding this comment.
Not sure why you removed it, since it can be useful in the logs, but I guess we don't really need it neither.
There was a problem hiding this comment.
It was duplicated. In my tests there was still one [init] prefix left. Before this change there were two, which felt a bit weird.
|
I won't have time to add tests for this myself anytime soon, but I've filed #1702 to track. |
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Fixes gopasspw#1693 RELEASE_NOTES=[BUGFIX] Invalidate GPG key list after generation Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1693
RELEASE_NOTES=[BUGFIX] Invalidate GPG key list after generation
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org