Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the GPG Onboarding Wizard #1702

Open
dominikschulz opened this issue Jan 12, 2021 · 5 comments
Open

Add tests for the GPG Onboarding Wizard #1702

dominikschulz opened this issue Jan 12, 2021 · 5 comments
Labels
good-first-issue Good for beginners starting to contribute Hacktoberfest help-wanted
Milestone

Comments

@dominikschulz
Copy link
Member

The Onboarding Wizard is largely untested.

We should add some automated tests to capture the primary user journeys here.

@dominikschulz dominikschulz added good-first-issue Good for beginners starting to contribute help-wanted labels Jan 12, 2021
@dominikschulz dominikschulz added this to the 1.x.x milestone Jan 12, 2021
@AnomalRoil AnomalRoil modified the milestones: 1.x.x, 1.11.1 Jan 12, 2021
@dominikschulz dominikschulz modified the milestones: 1.12.0, 1.12.1 Jan 21, 2021
@AnomalRoil AnomalRoil modified the milestones: 1.12.1, 1.13.0 Sep 29, 2021
@JoelLau
Copy link
Contributor

JoelLau commented Oct 4, 2024

hihi, can i check if this change is still required? i would like to contribute to this directory as part of this year's hacktoberfest

@dominikschulz
Copy link
Member Author

@JoelLau this is still in need of better tests. But I have no idea how tricky this is since it's a lot of user interactions (terminal input). Feel free to a give it a try.

@JoelLau
Copy link
Contributor

JoelLau commented Oct 18, 2024

@dominikschulz having a little trouble with my local setup. do you happen to have come across this error before?

$ go run . setup
# github.com/kbinani/screenshot
../../../../go/pkg/mod/github.com/kbinani/screenshot@v0.0.0-20230812210009-b87d31814237/screenshot_darwin.go:10:9: error: 'CGDisplayCreateImageForRect' is unavailable: obsoleted in macOS 15.0 - Please use ScreenCaptureKit instead.
   10 |         return CGDisplayCreateImageForRect(display, rect);
      |                ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDirectDisplay.h:391:33: note: 'CGDisplayCreateImageForRect' has been explicitly marked unavailable here
  391 | CG_EXTERN CGImageRef __nullable CGDisplayCreateImageForRect(
      |                                 ^
1 error generated.

@dominikschulz
Copy link
Member Author

@JoelLau that looks like a deprecation notice from Apple. We can try updating the screenshot package. If that doesn't work we should report the issue upstream.

@AnomalRoil
Copy link
Member

I think it should work with the latest master, thanks kbinani/screenshot#24
Sadly that project isn't tagging its releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for beginners starting to contribute Hacktoberfest help-wanted
Projects
None yet
Development

No branches or pull requests

3 participants