-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mounts' config ignored in 1.7.0 when using commands with --store option #793
Comments
Thank you very much for reporting this issue. Unfortunately I can't seem to reproduce it. Please try to run the commands again with |
Sorry for the chosen words. I don't know if Steps for this interaction:
... (after setup) ...
Note the request for ssh's password input before Even if The next command was in local new server (described in step 2):
(0x0123456789ABCDEF is gpg key for Someone < someone@somewhere.tld >) I didn't use
So the issue itself is that, even if config for root and each mount/store are set to Is there any other info that needs to be provided to analyze how to proceed? |
I'm not sure if I understand correctly, but having the commits show up in Unfortunately you seem to have removed most of the relevant |
About the quoted part, I only removed repeated
It does make sense locally, but not remotely, which was done. I didn't put the remote output, but the remote history is the same as the local one, so a |
Ok, I'll try to reproduce. |
Just an update: I'm reading the code in master branch and cross-compiled today from macOS to Linux and the issue still persists (tested both by using remote repo access as ssh and as https and both tries to pull before reencrypting secrets).
Currently, I am trying to find where such pull occurs, given that it happens between
and
(based on the output of step 3 in third comment of this issue) |
Ok, thanks a lot for these pointers. Now I found the place where the push/pull occurs: https://github.com/gopasspw/gopass/blob/master/pkg/store/sub/recipients.go#L252 Probably another place where the config isn't properly propagated. Will try to investigate/fix tomorrow. |
Using However, the commited code seems to introduce a bug in removal:
Key for
tl;dr: to add a recipient into a mount without syncing is ok. To remove a recipient from a mount, it does NOT find existing key to remove. |
Ah, thanks a lot. Actually this isn't a new bug, but a rather old one. |
Related to #700 and #701, I did a fresh server and user installation using gopass 1.7.0 and setup mounts from remote git repositories.
This is the related config:
Whenever I use a command related to a store, gopass syncs the remote repository before running the requested action, even if explicitly set to
autosync: false
.An example of command that syncs before and after running command:
Running a mount related command that does not require
--store
parameter does not sync with remote repository.An example of command that does not sync before and after running command:
Is there any other info that needs to be provided to analyze how to proceed?
The text was updated successfully, but these errors were encountered: