Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autosync for sub-store is ignored if root autosync is set to false #700

Closed
cjeffers opened this issue Mar 6, 2018 · 3 comments
Closed
Assignees

Comments

@cjeffers
Copy link

cjeffers commented Mar 6, 2018

I was trying to add a team password store (mounted as a sub-store). I do not have a personal or local repository, so i did not add a git remote for the local (root) store. I set the mounted team store's autosync to true:

gopass config --store <team-store> autosync true

But when inserting/changing secrets in the team store, the changes were not automatically pushed to the team remote. I could manually push them using gopass git -s <team-store> push. When I set the root store's autosync to true as well, then the team store automatically pushed to the remote, as expected.

I'm using gopass version 1.6.10

@dominikschulz
Copy link
Member

Thanks for reporting this. We had this issue before and I thought we fixed it already. Will double check.

@dominikschulz dominikschulz added the bug Defects label Mar 6, 2018
@ayharano
Copy link

ayharano commented Mar 7, 2018

Before opening a new issue, I searched if there was one somehow related and this seems to be a tangent case.

I'm also using gopass version 1.6.10 and setup to every store and mounts except one (let's name it <sub-store>) to confirm each and every time. However, when I run to insert, it asks for confirmation:

$ gopass insert <sub-store>/newsecret
Enter password for <sub-store>/newsecret:
Retype password for <sub-store>/newsecret:
Warning
gopass: Encrypting /newsecret for these recipients:
- 0x0123456789ABCDEF - User Name <email@example.tld>

Do you want to continue? [Y/n]: 

Config output:

$ gopass config
root store config:
  askformore: false
  autoimport: false
  autosync: false
  cliptimeout: 45
  nocolor: true
  noconfirm: false
  nopager: false
  path: /path/to/root
  safecontent: false
  usesymbols: false
mount 'another' config:
  path: /path/to/another
mount '<sub-store>' config:
  noconfirm: true
  path: /path/to/sub-store
mount 'one-more' config:
  path: /path/to/one-more

For me, it seemed to be a related case. If it is not, how to proceed? Open a new issue?

@dominikschulz
Copy link
Member

@ayharano Indeed, this could be related. For the time being I'd like to track this in this issue. Thanks for reporting it!

@dominikschulz dominikschulz added bug/confirmed and removed bug Defects labels Mar 8, 2018
@dominikschulz dominikschulz self-assigned this Mar 8, 2018
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Mar 8, 2018
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Mar 8, 2018
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Mar 8, 2018
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Mar 8, 2018
dominikschulz added a commit that referenced this issue Mar 8, 2018
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants