-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update protos circa 2022-04-04 #310
feat: update protos circa 2022-04-04 #310
Conversation
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 97.62% 92.20% -5.43%
==========================================
Files 48 48
Lines 7633 7596 -37
==========================================
- Hits 7452 7004 -448
- Misses 181 592 +411
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I am willing to take the coverage drop, most of it is from the generated code anyway. |
@@ -85,7 +85,7 @@ def __preprocess_rest_ubla(cls, ubla): | |||
def __preprocess_rest_pap(cls, pap): | |||
pap = pap.upper() | |||
if pap == "UNSPECIFIED" or pap == "INHERITED": | |||
return "PUBLIC_ACCESS_PREVENTION_UNSPECIFIED" | |||
return "INHERITED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only strange change; went from unspecified to inherited;
No description provided.