Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update protos circa 2022-04-04 #310

Merged
merged 2 commits into from
Apr 4, 2022
Merged

feat: update protos circa 2022-04-04 #310

merged 2 commits into from
Apr 4, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Apr 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #310 (215cdef) into main (c80ed76) will decrease coverage by 5.42%.
The diff coverage is 49.51%.

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   97.62%   92.20%   -5.43%     
==========================================
  Files          48       48              
  Lines        7633     7596      -37     
==========================================
- Hits         7452     7004     -448     
- Misses        181      592     +411     
Flag Coverage Δ
unittests 92.20% <49.51%> (-5.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
google/storage/v2/storage_pb2.py 37.60% <ø> (-62.40%) ⬇️
tests/test_common.py 99.79% <ø> (ø)
tests/test_grpc_server.py 99.84% <ø> (ø)
google/iam/v1/iam_policy_pb2.py 48.27% <21.05%> (-51.73%) ⬇️
google/iam/v1/policy_pb2.py 63.63% <38.46%> (-36.37%) ⬇️
google/iam/v1/options_pb2.py 76.47% <50.00%> (-23.53%) ⬇️
testbench/acl.py 92.12% <89.47%> (-1.86%) ⬇️
gcs/bucket.py 98.89% <100.00%> (+0.27%) ⬆️
gcs/object.py 98.67% <100.00%> (-0.01%) ⬇️
testbench/common.py 98.67% <100.00%> (-0.01%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80ed76...215cdef. Read the comment docs.

@coryan coryan marked this pull request as ready for review April 4, 2022 16:57
@coryan coryan requested a review from a team as a code owner April 4, 2022 16:57
@coryan
Copy link
Contributor Author

coryan commented Apr 4, 2022

I am willing to take the coverage drop, most of it is from the generated code anyway.

@coryan coryan enabled auto-merge (squash) April 4, 2022 16:58
@@ -85,7 +85,7 @@ def __preprocess_rest_ubla(cls, ubla):
def __preprocess_rest_pap(cls, pap):
pap = pap.upper()
if pap == "UNSPECIFIED" or pap == "INHERITED":
return "PUBLIC_ACCESS_PREVENTION_UNSPECIFIED"
return "INHERITED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only strange change; went from unspecified to inherited;

@coryan coryan merged commit d53752b into googleapis:main Apr 4, 2022
@coryan coryan deleted the feat-update-protos-circa-2022-04-04 branch April 4, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants