Skip to content

Commit

Permalink
feat: update protos circa 2022-04-04 (#310)
Browse files Browse the repository at this point in the history
  • Loading branch information
coryan authored Apr 4, 2022
1 parent c80ed76 commit d53752b
Show file tree
Hide file tree
Showing 14 changed files with 574 additions and 6,052 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ __pycache__/
.coverage*
cov.xml
googleapis_storage_testbench.egg-info/
coverage.xml
30 changes: 9 additions & 21 deletions gcs/bucket.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __preprocess_rest_ubla(cls, ubla):
def __preprocess_rest_pap(cls, pap):
pap = pap.upper()
if pap == "UNSPECIFIED" or pap == "INHERITED":
return "PUBLIC_ACCESS_PREVENTION_UNSPECIFIED"
return "INHERITED"
return pap

@classmethod
Expand Down Expand Up @@ -213,9 +213,6 @@ def __postprocess_rest_ubla(cls, ubla):

@classmethod
def __postprocess_rest_pap(cls, pap):
# '..._unspecified' is the default enum values, and default values
# are not present in proto3
assert pap != "public_access_prevention_unspecified"
return pap.lower()

@classmethod
Expand Down Expand Up @@ -371,11 +368,7 @@ def __insert_predefined_acl(cls, metadata, predefined_acl, context):
def __insert_predefined_default_object_acl(
cls, metadata, predefined_default_object_acl, context
):
if (
predefined_default_object_acl == ""
or predefined_default_object_acl
== storage_pb2.PREDEFINED_OBJECT_ACL_UNSPECIFIED
):
if predefined_default_object_acl is None or predefined_default_object_acl == "":
return
if metadata.iam_config.uniform_bucket_level_access.enabled:
testbench.error.invalid(
Expand Down Expand Up @@ -436,11 +429,9 @@ def init(cls, request, context):
testbench.acl.extract_predefined_default_object_acl(request, context)
)
if (
predefined_default_object_acl
== storage_pb2.PREDEFINED_OBJECT_ACL_UNSPECIFIED
predefined_default_object_acl is None
or predefined_default_object_acl == ""
):
predefined_default_object_acl = storage_pb2.OBJECT_ACL_PROJECT_PRIVATE
elif predefined_default_object_acl == "":
predefined_default_object_acl = "projectPrivate"
elif is_uniform:
testbench.error.invalid(
Expand Down Expand Up @@ -468,16 +459,13 @@ def init_grpc(cls, request, context):
cls._init_defaults(metadata, context)
metadata.bucket_id = request.bucket_id
metadata.name = "projects/_/buckets/" + request.bucket_id
predefined_acl = (
request.predefined_acl
if request.predefined_acl != storage_pb2.PREDEFINED_BUCKET_ACL_UNSPECIFIED
else storage_pb2.BUCKET_ACL_PROJECT_PRIVATE
)
predefined_acl = "projectPrivate"
if request.predefined_acl is not None and request.predefined_acl != "":
predefined_acl = request.predefined_acl
predefined_default_object_acl = (
request.predefined_default_object_acl
if request.predefined_default_object_acl
!= storage_pb2.PREDEFINED_OBJECT_ACL_UNSPECIFIED
else storage_pb2.OBJECT_ACL_PROJECT_PRIVATE
if request.predefined_default_object_acl != ""
else "projectPrivate"
)
cls.__insert_predefined_acl(metadata, predefined_acl, context)
cls.__insert_predefined_default_object_acl(
Expand Down
15 changes: 2 additions & 13 deletions gcs/object.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,7 @@ def __init__(self, metadata, media, bucket):

@classmethod
def __insert_predefined_acl(cls, metadata, bucket, predefined_acl, context):
if (
predefined_acl == ""
or predefined_acl
== storage_pb2.PredefinedObjectAcl.PREDEFINED_OBJECT_ACL_UNSPECIFIED
):
if predefined_acl == "" or predefined_acl is None:
return
if bucket.iam_config.uniform_bucket_level_access.enabled:
testbench.error.invalid(
Expand Down Expand Up @@ -176,14 +172,7 @@ def init(cls, request, metadata, media, bucket, is_destination, context):
predefined_acl = testbench.acl.extract_predefined_acl(
request, is_destination, context
)
if (
predefined_acl
== storage_pb2.PredefinedObjectAcl.PREDEFINED_OBJECT_ACL_UNSPECIFIED
):
predefined_acl = (
storage_pb2.PredefinedObjectAcl.OBJECT_ACL_PROJECT_PRIVATE
)
elif predefined_acl == "":
if predefined_acl is None or predefined_acl == "":
predefined_acl = "projectPrivate"
elif is_uniform:
testbench.error.invalid(
Expand Down
258 changes: 39 additions & 219 deletions google/iam/v1/iam_policy_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit d53752b

Please sign in to comment.