-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust native-image config for spring-cloud-gcp #3617
Conversation
Context: upgrading to GraalVM for JDK 23 Updating the image support in spring (GoogleCloudPlatform/spring-cloud-gcp#3536) caused errors at analysis time solved by GoogleCloudPlatform/spring-cloud-gcp@d3f6185 Gax seems to be a better place for this kind of configs.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @mpeddada1 should be the final approval
From discussion with @blakeli0, will investigate the root cause of the need for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is harmless so it is OK to merge it in if it is blocking GraalVM upgrade. But we need to understand why we have to make these changes and document them.
@blakeli0 I confirmed You'll find that almost every native test fails at image build time, with some of the sub-jobs pointing exactly to the same issue fixed in this PR.
Moreover, the runs in Graal JDK 21 without the
|
Context: upgrading to GraalVM for JDK 23 Updating the image support in spring (GoogleCloudPlatform/spring-cloud-gcp#3536) caused errors at analysis time solved by GoogleCloudPlatform/spring-cloud-gcp@d3f6185 Gax seems to be a better place for this kind of configs.
Context: upgrading to GraalVM for JDK 23
Updating the image support in spring (GoogleCloudPlatform/spring-cloud-gcp#3536) caused errors at analysis time solved by GoogleCloudPlatform/spring-cloud-gcp@d3f6185
Gax seems to be a better place for this kind of configs.