Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize native image test configs #3638

Open
diegomarquezp opened this issue Feb 12, 2025 · 2 comments
Open

Centralize native image test configs #3638

diegomarquezp opened this issue Feb 12, 2025 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@diegomarquezp
Copy link
Contributor

In the release starting Feb 3, we had to add a few configurations to HW repos. We need to centralize them at the gax level.

Note that most of this config involves initializing junit classes into the image heap, for which I used src/test/.../native-image in order to not have these classes put in the production image heap.

Ideally, we should move all of these initializations to gax and then remove these configs once the following sdk-platform-config is released.
@diegomarquezp diegomarquezp changed the title Centralize native image test config Centralize native image test configs Feb 12, 2025
@diegomarquezp
Copy link
Contributor Author

The commits may not capture all changes, but for completion here are the involved PRs as a pointer to which classes should be moved

@diegomarquezp diegomarquezp added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 13, 2025
@diegomarquezp
Copy link
Contributor Author

More context into why these initializations became necessary (it's due to --strict-image-heap being enforced by default since GraalVM for JDK 22) in #3617 (comment)

@BenWhitehead BenWhitehead mentioned this issue Feb 13, 2025
Merged
1 task
@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @diegomarquezp