tests: Update the golden files' copyright to 2025 #3513
Conversation
| @@ -61,6 +62,7 @@ void initialSanityCheck() { | |||
| assertTrue(context.containsServices()); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
IIUC, this is a manual fix and this @Disabled is added temporarily and will be removed after this update is merged?
There was a problem hiding this comment.
No, I was testing if adding @Disabled to this test is going to fix most of the issues or not. It proves not, we need to update integration tests, showcase tests, hermetic build tests and spring-cloud-gcp tests. I'm going to update all the golden files in this repo for now to unblock the release, and create issues for improvements.
…lden files' copyright to 2025.
|
|
|
/gcbrun |
1 similar comment
|
/gcbrun |
…yright to 2025 (#3550) follow-up to #3513, Changes in this PR: - generated by ` mvn test -DupdateUnitGoldens ` from gapic-generator-java/. Note that unit tests without this change did not fail. Filed #3556 to investigate and maybe remove these in the future. - library-generation unit test golden files. They are causing test failures in https://github.com/googleapis/sdk-platform-java/actions/runs/12659566586/job/35278951040?pr=3462 These 2 files are used in unit tests to test logic in owlbot to insert header when they are missing. e.g. https://github.com/googleapis/sdk-platform-java/blob/67f5ea23f50eaf57925cdf34d51c7b0bfcc67cf3/hermetic_build/library_generation/owlbot/synthtool/languages/java.py#L113-L116
Fixes #3512.
The copyright year for GAPIC generated files are automatically set to current year. This creates a problem that all the tests are going to automatically fail when new year comes. Updating all the golden files' copyright to 2025 in this PR for now.
There are golden test files need to be updated in spring-cloud-gcp as well since it is dependent on the generator.
In the future, we need to come up with a better strategy that the tests do not fail automatically, created an issue #3547 to track the future enhancement.