investigate if test golden files are orphaned #3556
Labels
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Comments
zhumin8
added a commit
that referenced
this issue
Jan 7, 2025
…yright to 2025 (#3550) follow-up to #3513, Changes in this PR: - generated by ` mvn test -DupdateUnitGoldens ` from gapic-generator-java/. Note that unit tests without this change did not fail. Filed #3556 to investigate and maybe remove these in the future. - library-generation unit test golden files. They are causing test failures in https://github.com/googleapis/sdk-platform-java/actions/runs/12659566586/job/35278951040?pr=3462 These 2 files are used in unit tests to test logic in owlbot to insert header when they are missing. e.g. https://github.com/googleapis/sdk-platform-java/blob/67f5ea23f50eaf57925cdf34d51c7b0bfcc67cf3/hermetic_build/library_generation/owlbot/synthtool/languages/java.py#L113-L116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
context: #3550
At start of 2025, #3547 causes test failures on license header year difference. These tests are missed in the original fix, and did not cause any ci test failures without the fix.
Suspecting that these tests are not actually used in test assert, or might be orphaned golden files that used to be used, and did not remove.
Investigate and remove these golden files if not used.
The text was updated successfully, but these errors were encountered: