Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add development installation instructions #64

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jun 29, 2017

Includes conda install steps for dependencies.

Closes #63.

@codecov-io
Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #64 into master will decrease coverage by 45.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   73.44%   28.24%   -45.2%     
==========================================
  Files           4        4              
  Lines        1540     1540              
==========================================
- Hits         1131      435     -696     
- Misses        409     1105     +696
Impacted Files Coverage Δ
pandas_gbq/gbq.py 19.35% <0%> (-55.98%) ⬇️
pandas_gbq/tests/test_gbq.py 27.94% <0%> (-54.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78cdf9a...7b44ffa. Read the comment docs.

@tswast tswast requested a review from parthea June 30, 2017 23:32
~~~~~

To install packages in development mode using conda, first
install the conda build tools package in your root conda environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicating some of contributing.rst

you can move there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved these instructions all to contributing.rst.

@@ -32,6 +32,60 @@ Install from Source
$ pip install git+https://github.com/pydata/pandas-gbq.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would remove the build some source section (or u can leave the header and just point to contributing.rst)


.. code-block:: shell

$ conda install --channel conda-forge \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the point of this is you don't have to specify secondary deps, they will simply be installed via the dependency graph. it looks like you install

conda create -n foo --dry google-auth-oauthlib google-api-python-client pandas google-auth-httplib2

though I am suprised that google-auth is actually a dep of the google-auth-oauthlib (and httplib2), you usually don't do it this way, rather installing google-auth should install all libs under its tree, so this is a bit odd.


.. code-block:: shell

$ conda develop .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use python setup.py develop rather than conda develop


.. code-block:: shell

$ conda create --no-deps -n pandas-gbq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this all in one go, see below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


.. code-block:: shell

$ conda install conda-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need conda-build

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.


$ conda install conda-build

Optionally, create a new conda environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not optional, you always do this.


.. code-block:: shell

$ pip install -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generally don't use pip to install things when we have proper conda packages. sure you can, but its not the first thing you do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

I'd like to keep these instructions for folks that aren't using conda. I've moved the section after and added a disclaimer that it's not necessary if using conda.

@jreback jreback added the docs label Jul 1, 2017
@jreback jreback added this to the 0.2.0 milestone Jul 1, 2017
@tswast tswast force-pushed the doc-63 branch 3 times, most recently from 9b622e3 to 40c4333 Compare July 5, 2017 16:29
Includes conda install steps for dependencies.
@jreback
Copy link
Contributor

jreback commented Jul 6, 2017

yeah see #20 about the coverage issue. Maybe need to skip the user checks for this.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tswast !

@parthea parthea merged commit a8792ba into googleapis:master Jul 6, 2017
@tswast tswast deleted the doc-63 branch July 6, 2017 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants