-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage when gbq credentials are not provided #20
Comments
yeah I realized that now :> we have a very low check on the PR's anyhow |
A local emulator would be a good way to provide such a use-case. Google has them for some services like Bigtable and Cloud Pub/Sub, but there isn't one for BigQuery. |
OK thanks. |
I believe this project already has some secret keys used to build on merge. Some CI systems allow accessing secret keys after a PR from a fork has been manually reviewed by adding a GitHub tag/label to the PR. I don't believe Travis has this feature, though. |
ok thx |
Unfortunately I don't think there's a BigQuery mocking library like there is with some other Google products. I agree that would radically improve the testing iteration. But until then, I propose to close this as out-of-scope; unless people think I'm overestimating how difficult it would be to build the mocks |
Yeah, no BigQuery emulator. It does make unit testing annoying / infeasible. |
By default, the majority of pandas-gbq unit tests are skipped on forks of pandas-gbq because Google BigQuery integration testing requires credentials. This causes code coverage to appear low on pull requests from forks. One potential way to increase the code coverage reported in pull requests from forks is to use
mock
to stub external requests.https://docs.python.org/3.6/library/unittest.mock.html
The text was updated successfully, but these errors were encountered: