Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests flexible to auth method #109

Closed
max-sixty opened this issue Jan 12, 2018 · 1 comment
Closed

Tests flexible to auth method #109

max-sixty opened this issue Jan 12, 2018 · 1 comment

Comments

@max-sixty
Copy link
Contributor

At the moment, each auth method (Service key path / service key contents / user) has a separate class with tested functions

I think we could make this much simpler and more flexible - have a pytest fixture that generates a GBQConnector, and use that in each function. Then we can test on whatever auth method is available (and set a minimum if preferred: #72)

Separately, there is a lot of setup & teardown code that could be simplified through fixtures. And some manual test_ids that could be automated through pytest

@max-sixty
Copy link
Contributor Author

This was committed to master a while ago. Plenty of improvements to the test infra are still possible, but the bulk of this is in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant