Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Load integration test creds from env vars #29

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 20, 2017

Load the credentials for integration tests from environment variables.
This will make it easier to run the integration tests locally. Also adds
instructions for running the integrations tests locally.

Closes #27.

Load the credentials for integration tests from environment variables.
This will make it easier to run the integration tests locally. Also adds
instructions for running the integrations tests locally.

Closes GH#27.
@codecov-io
Copy link

Codecov Report

Merging #29 into master will decrease coverage by 39.61%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #29       +/-   ##
==========================================
- Coverage   76.51%   36.9%   -39.62%     
==========================================
  Files           4       4               
  Lines        1516    1512        -4     
==========================================
- Hits         1160     558      -602     
- Misses        356     954      +598
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 37.44% <71.42%> (-49.2%) ⬇️
pandas_gbq/gbq.py 31.09% <0%> (-47.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fe0de...d5dce2c. Read the comment docs.

@tswast
Copy link
Collaborator Author

tswast commented Apr 20, 2017

Note: the Travis test run is here: https://travis-ci.org/tswast/pandas-gbq/builds/224148383

I've set the secret environment variables as described in http://pandas-gbq.readthedocs.io/en/latest/contributing.html#running-google-bigquery-integration-tests

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@parthea parthea merged commit 96e9df9 into googleapis:master Apr 21, 2017
@tswast tswast deleted the it branch April 21, 2017 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants