-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Improve the documentation for running integration tests locally #27
Comments
http://pandas-gbq.readthedocs.io/en/latest/contributing.html is pretty comprehensive |
of course if u think it needs updates then pls send a PR |
I set the following when running integration tests locally:
I scanned through the contributing docs and it appears that this step is missing (it wasn't in the https://github.com/pydata/pandas-gbq/blob/master/pandas_gbq/tests/test_gbq.py#L22 |
@tswast The integration tests are skipped if you do not provide credentials/project id . I'm open to improving the local integration testing process as well. Some users may not want to use their default gcloud credentials to run |
That makes sense to skip, even if default gcloud credentials are available. I'll try running through the current workflow this morning to see how it goes. |
Question: Does it make any sense to populate PRIVATE_KEY_JSON_PATH but not PRIVATE_KEY_JSON_CONTENTS? I'm thinking of always loading the contents of the key file in |
@tswast You're right. It seems redundant to have |
I'd love to see a TESTING.md file that showed how to run the tests locally before sending off a PR.
I can run
pytest
but is that running the integration tests, too? It seemed to run a bit fast for that to be the case.The text was updated successfully, but these errors were encountered: