Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: link to contributing guide #28

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 20, 2017

Full contributing (and testing) instructions are included in the docs.
http://pandas-gbq.readthedocs.io/en/latest/contributing.html

I didn't find these docs #27 because I didn't expect them to be in the user documentation, and I'm used to looking for a CONTRIBUTING file.

By creating a CONTRIBUTING.md file, GitHub users will be more likely to
find them. See: https://github.com/blog/1184-contributing-guidelines

@codecov-io
Copy link

codecov-io commented Apr 20, 2017

Codecov Report

Merging #28 into master will decrease coverage by 39.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
- Coverage   76.51%   36.87%   -39.65%     
===========================================
  Files           4        4               
  Lines        1516     1516               
===========================================
- Hits         1160      559      -601     
- Misses        356      957      +601
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 37.38% <0%> (-49.26%) ⬇️
pandas_gbq/gbq.py 31.09% <0%> (-47.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb22b17...aee48e6. Read the comment docs.

@tswast tswast changed the title Add link to contributing guide. DOC: link to contributing guide Apr 20, 2017
Full contributing (and testing) instructions are included in the docs.
http://pandas-gbq.readthedocs.io/en/latest/contributing.html

I didn't find these docs (GH27) because I didn't expect them to be in
the user documentation, and I'm used to looking for a CONTRIBUTING file.

By creating a CONTRIBUTING.md file, GitHub users will be more likely to
find them. See: https://github.com/blog/1184-contributing-guidelines
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tswast !

@parthea parthea merged commit 22fe0de into googleapis:master Apr 20, 2017
@tswast tswast deleted the contributing branch April 20, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants