Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

System tests fail with request error #108

Closed
JustinBeckwith opened this issue Aug 30, 2018 · 1 comment
Closed

System tests fail with request error #108

JustinBeckwith opened this issue Aug 30, 2018 · 1 comment
Assignees
@fhinkel
Labels
api: translation Issues related to the nodejs-translate API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JustinBeckwith
Copy link
Contributor

This was getting masked by a problem with the logic in the system tests, which I'm about to fix. CI is failing for this here:
https://circleci.com/gh/googleapis/nodejs-translate/3384

It looks like this is related to the transition to teeny-request:

1) translate
       authentication
         should use an API key to authenticate:
     TypeError: Cannot read property 'defaults' of undefined
      at Util.makeRequest (node_modules/@google-cloud/common/src/util.ts:624:45)
      at Translate.request (src/index.ts:551:10)
      at Translate.getLanguages (src/index.ts:354:10)
      at Translate.wrapper (node_modules/@google-cloud/promisify/src/index.ts:73:29)
      at Context.it (system-test/translate.ts:165:17)
@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 30, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Aug 30, 2018 •
edited
Loading

I see, we're trying to use config.request in common, but we set config.requestModule here.

@fhinkel fhinkel mentioned this issue Sep 4, 2018
Closed
fhinkel added a commit that referenced this issue Sep 4, 2018
@fhinkel
fix: set request module
9d97dce 
The field is called `request`, not `requestModule`.

Fixes: #108
@fhinkel fhinkel mentioned this issue Sep 4, 2018
Merged
JustinBeckwith pushed a commit that referenced this issue Sep 4, 2018
@fhinkel @JustinBeckwith
fix: set request module (#112)
782a7ae 
The field is called `request`, not `requestModule`.

Fixes: #108
@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 4, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: translation Issues related to the nodejs-translate API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
sofisl pushed a commit to googleapis/google-cloud-node that referenced this issue Nov 10, 2022
@fhinkel @JustinBeckwith
fix: set request module (#112)
2d9eb12 
The field is called `request`, not `requestModule`.

Fixes: googleapis/nodejs-translate#108
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fhinkel fhinkel

Labels
api: translation Issues related to the nodejs-translate API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhinkel @JustinBeckwith @yoshi-automation