Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Use teeny-request #91

Closed
wants to merge 1 commit into from
Closed

Use teeny-request #91

wants to merge 1 commit into from

Conversation

JustinBeckwith
Copy link
Contributor

@fhinkel the system tests currently fail with this error:

dns
    1) "before all" hook
(node:39906) UnhandledPromiseRejectionWarning: TypeError: config.request.defaults is not a function
    at Util.makeRequest (/Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:624:45)
    at onAuthenticated (/Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:565:24)
    at /Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:577:15
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:39906) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:39906) UnhandledPromiseRejectionWarning: TypeError: config.request.defaults is not a function
    at Util.makeRequest (/Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:624:45)
    at onAuthenticated (/Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:565:24)
    at /Users/beckwith/Code/nodejs-dns/node_modules/@google-cloud/common/src/util.ts:577:15
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:39906) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
^CTerminated: 15

Is this a bug in nodejs-common? Or am I doing something wrong here?

@JustinBeckwith JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 4, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2018
@ghost ghost assigned JustinBeckwith Sep 4, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Sep 4, 2018

Good morning! It's a bug in common that I'm about to fix. See googleapis/nodejs-translate#108 (comment)

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once common is fixed

@fhinkel
Copy link
Contributor

fhinkel commented Sep 4, 2018

How do you know they're failing? Locally? The CI looks green. Or is that because it's a fork?

@JustinBeckwith
Copy link
Contributor Author

They are failing locally.

fhinkel added a commit that referenced this pull request Sep 4, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Sep 4, 2018

Closed via 5c074b7

@fhinkel fhinkel closed this Sep 4, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Sep 4, 2018

Oh, I see. It needs to be
const teenyRequest = require('teeny-request').teenyRequest;

Let me figure out if I want to change to in teeny to be more like request or at least update the docs for teeny.

sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants