This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good morning! It's a bug in |
fhinkel
reviewed
Sep 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once common is fixed
fhinkel
added a commit
that referenced
this pull request
Sep 4, 2018
How do you know they're failing? Locally? The CI looks green. Or is that because it's a fork? |
They are failing locally. |
fhinkel
added a commit
that referenced
this pull request
Sep 4, 2018
Closed via 5c074b7 |
Oh, I see. It needs to be Let me figure out if I want to change to in |
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
This human has signed the Contributor License Agreement.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fhinkel the system tests currently fail with this error:
Is this a bug in nodejs-common? Or am I doing something wrong here?