Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable grpc channel management support for spanner client. #436

Closed
wants to merge 4 commits into from
Closed

Enable grpc channel management support for spanner client. #436

wants to merge 4 commits into from

Conversation

WeiranFang
Copy link
Contributor

@WeiranFang WeiranFang commented Nov 14, 2018 •
edited
Loading

Enabling grpc connection management for Spanner client using grpc-gcp library. By default it will be using a channel pool of size 10, and each with 100 max concurrent streams.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
JustinBeckwith
JustinBeckwith suggested changes Nov 14, 2018
View reviewed changes
package.json
@@ -53,7 +53,8 @@
"events-intercept": "^2.0.0",
"extend": "^3.0.1",
"google-auth-library": "^2.0.0",
"google-gax": "^0.22.0",
"google-gax": "^0.22.1",
"grpc-gcp": "^0.1.0",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2018
alexander-fenster
alexander-fenster suggested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not manually edit files inside src/v*. See my comment above for detailed explanations, or feel free to set up a meeting and talk to me if you have any questions!

@JustinBeckwith
Copy link
Contributor

It looks like the call here is to move this logic over to google-gax :) I am going to close this out for now!

@WeiranFang WeiranFang mentioned this pull request Jan 19, 2019
Merged
@WeiranFang WeiranFang mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith requested changes

@crwilcox crwilcox crwilcox approved these changes

@callmehiphop callmehiphop callmehiphop left review comments

@alexander-fenster alexander-fenster alexander-fenster requested changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WeiranFang @JustinBeckwith @crwilcox @callmehiphop @alexander-fenster @googlebot