Add grpc-gcp support in gax #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JustinBeckwith @alexander-fenster , do you mind take a look when possible? Thanks a bunch! |
src/grpc.ts
Outdated
| } | ||
| }); | ||
| const apiConfigDefition = options['grpc_gcp.apiConfig']; |
There was a problem hiding this comment.
typo: should be Definition
alexander-fenster
approved these changes
Jan 22, 2019
|
Hi @alexander-fenster can you help merge this? And may I ask what's the timeline for the next release? Thx! |
|
I'm releasing 0.25.0 in #402. |
|
@WeiranFang It's released. |
|
Thanks @alexander-fenster ! I'll pin it in googleapis/nodejs-spanner#503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in googleapis/nodejs-spanner#436 , we decided to put the grpc-gcp related logic into gax, while in client library, we only need to add a new entry with key named
grpc_gcp.apiConfiginto the client options, so that the gax will enable the grpc-gcp support only when the entry exists.