fix: adding option to skip back up tests #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skuruppu
approved these changes
Aug 4, 2021
| @@ -37,6 +37,7 @@ import {google} from '../protos/protos'; | |||
| import CreateDatabaseMetadata = google.spanner.admin.database.v1.CreateDatabaseMetadata; | |||
| import CreateBackupMetadata = google.spanner.admin.database.v1.CreateBackupMetadata; | |||
|
|
|||
| const SKIP_BACKUPS = process.env.SKIP_BACKUPS; | |||
There was a problem hiding this comment.
Minor nit on the name.
Suggested change
| const SKIP_BACKUPS = process.env.SKIP_BACKUPS; | |
| const SKIP_BACKUP_TESTS = process.env.SKIP_BACKUP_TESTS; |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [5.13.0](https://www.github.com/googleapis/nodejs-spanner/compare/v5.12.0...v5.13.0) (2021-08-04) ### Features * add GetInstanceConfig function ([#1438](https://www.github.com/googleapis/nodejs-spanner/issues/1438)) ([24b3524](https://www.github.com/googleapis/nodejs-spanner/commit/24b35242d3ce52e16a5fa04ff949ca44a6608396)) ### Bug Fixes * adding option to skip back up tests ([#1445](https://www.github.com/googleapis/nodejs-spanner/issues/1445)) ([e189e5a](https://www.github.com/googleapis/nodejs-spanner/commit/e189e5a03c6e40d3adc64233e72d9d9748e0bc0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
asthamohta
pushed a commit
to asthamohta/nodejs-spanner
that referenced
this pull request
Sep 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [5.13.0](https://www.github.com/googleapis/nodejs-spanner/compare/v5.12.0...v5.13.0) (2021-08-04) ### Features * add GetInstanceConfig function ([googleapis#1438](https://www.github.com/googleapis/nodejs-spanner/issues/1438)) ([24b3524](https://www.github.com/googleapis/nodejs-spanner/commit/24b35242d3ce52e16a5fa04ff949ca44a6608396)) ### Bug Fixes * adding option to skip back up tests ([googleapis#1445](https://www.github.com/googleapis/nodejs-spanner/issues/1445)) ([e189e5a](https://www.github.com/googleapis/nodejs-spanner/commit/e189e5a03c6e40d3adc64233e72d9d9748e0bc0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set environment variable as following to skip backup tests:
export SKIP_BACKUPS=true