feat: add GetInstanceConfig function #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skuruppu
reviewed
Jul 29, 2021
src/index.ts
Outdated
| */ | ||
| getInstanceConfig( | ||
| name: string, | ||
| optionsOrCallback?: CallOptions | GetInstanceConfigCallback, |
There was a problem hiding this comment.
I might be overthinking it here but should we future-proof the options by making a new interface for GetInstanceConfigOptions that includes gaxOptions? I feel like recently, we've introduced lots of new options into existing RPCs that made it very tricky to support in Node.js
There was a problem hiding this comment.
That's true. I've updated the function definition to use a specific GetInstanceConfigOptions that includes gax options.
…anner into get-instance-config
skuruppu
approved these changes
Jul 30, 2021
olavloite
added a commit
that referenced
this pull request
Aug 3, 2021
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
olavloite
added a commit
that referenced
this pull request
Aug 3, 2021
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [5.13.0](https://www.github.com/googleapis/nodejs-spanner/compare/v5.12.0...v5.13.0) (2021-08-04) ### Features * add GetInstanceConfig function ([#1438](https://www.github.com/googleapis/nodejs-spanner/issues/1438)) ([24b3524](https://www.github.com/googleapis/nodejs-spanner/commit/24b35242d3ce52e16a5fa04ff949ca44a6608396)) ### Bug Fixes * adding option to skip back up tests ([#1445](https://www.github.com/googleapis/nodejs-spanner/issues/1445)) ([e189e5a](https://www.github.com/googleapis/nodejs-spanner/commit/e189e5a03c6e40d3adc64233e72d9d9748e0bc0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
asthamohta
pushed a commit
to asthamohta/nodejs-spanner
that referenced
this pull request
Sep 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [5.13.0](https://www.github.com/googleapis/nodejs-spanner/compare/v5.12.0...v5.13.0) (2021-08-04) ### Features * add GetInstanceConfig function ([googleapis#1438](https://www.github.com/googleapis/nodejs-spanner/issues/1438)) ([24b3524](https://www.github.com/googleapis/nodejs-spanner/commit/24b35242d3ce52e16a5fa04ff949ca44a6608396)) ### Bug Fixes * adding option to skip back up tests ([googleapis#1445](https://www.github.com/googleapis/nodejs-spanner/issues/1445)) ([e189e5a](https://www.github.com/googleapis/nodejs-spanner/commit/e189e5a03c6e40d3adc64233e72d9d9748e0bc0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function for getting the details of a specific
InstanceConfig. This is a simple wrapper around theGetInstanceConfigRPC.