-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue#343 #353
Fix for Issue#343 #353
Conversation
@muraliQlogic: The requirement is to have a check that requires a family with a qualifier. The qualifier could be the empty string. This PR doesn't look right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to ensure that an empty qualifier passes the chunk transformer. Please revert everything else.
fam":"" is fine, but "fam":[null] is not ok. I believe the if statement checks for "fam":[null] rather than "fam":"". We should add a unit test to confirm that. @muraliQlogic, can you please change the the chunktransformer.js test for those requirements? |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 10
Lines ? 1287
Branches ? 0
=======================================
Hits ? 1287
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
@sduskis : I modified if condition to check for null or undefined qualifier. |
@muraliQlogic: Does |
Fixes #343