Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty column qualifiers should not be rejected #343

Closed
dmmcerlean opened this issue Oct 25, 2018 · 2 comments
Closed

Empty column qualifiers should not be rejected #343

dmmcerlean opened this issue Oct 25, 2018 · 2 comments
Assignees
@sduskis
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dmmcerlean
Copy link

Relevant code is here for reads: https://github.com/googleapis/nodejs-bigtable/blob/13e3d769/src/chunktransformer.js#L251

It's completely valid to use a column like "fam:" which has no qualifier
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 26, 2018
@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 28, 2018
@sduskis
Copy link
Contributor

sduskis commented Nov 2, 2018

@muraliQlogic, can you please take a look?

@muraliQlogic muraliQlogic mentioned this issue Nov 4, 2018
Merged
3 tasks
@sduskis
Copy link
Contributor

sduskis commented Nov 6, 2018

@dmmcerlean "fam":"" is fine, but "fam":[null] is not ok. I believe the if statement checks for "fam":[null] rather than "fam":"". We should add a unit test to confirm that.

@google-cloud-label-sync google-cloud-label-sync bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sduskis sduskis

Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sduskis @JustinBeckwith @stephenplusplus @dmmcerlean @yoshi-automation