Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Add sample demontrating how to create a job. #8422

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jun 19, 2019

This sample is intended for https://cloud.google.com/bigquery/docs/running-jobs

It demonstrates advanced features, such as overriding location
autodetection and overriding job ID generation.

cc @grant @shollyman @alixhami

This sample is intended for https://cloud.google.com/bigquery/docs/running-jobs

It demonstrates advanced features, such as overriding location
autodetection and overriding job ID generation.
@tswast tswast added api: bigquery Issues related to the BigQuery API. type: docs Improvement to the documentation for an API. labels Jun 19, 2019
@tswast tswast requested review from shollyman and a team June 19, 2019 00:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2019
@alixhami
Copy link
Contributor

I think it makes more sense to have the documentation about the location in the docs, rather than copied into a comment in each language's snippet.

I also don't think it's a good idea to put URLs in comments. It can become a problem if pages are moved or if this sample ends up being included on the page it's linking to.

@tseaver tseaver changed the title Add sample demontrating how to create a job. BigQuery: Add sample demontrating how to create a job. Jun 19, 2019
@tswast
Copy link
Contributor Author

tswast commented Jun 19, 2019

Removed the link and the comment about location autodetection. I'll make sure that is documented when I add the sample to the docs.

@tswast tswast merged commit c927c98 into googleapis:master Jun 19, 2019
@tswast tswast deleted the sample1713-create-job branch June 19, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants