Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Snippets: Use autodetected location #433

Merged
merged 2 commits into from
Jun 20, 2019
Merged

BigQuery Snippets: Use autodetected location #433

merged 2 commits into from
Jun 20, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 14, 2019

Use autodetected location.

In the example provided, it is written that The location must be specified, but the example works even without setting location for datasets located in US and asia-northeast1. Whether specifying location for an upload job is an absolute requirement or not is affecting an application I'm working on. Can you provide details?

See b/116968956

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@grant grant requested a review from alixhami June 15, 2019 00:54
@grant grant self-assigned this Jun 18, 2019
@grant grant requested review from shollyman and removed request for alixhami June 18, 2019 20:36
@tswast
Copy link
Contributor

tswast commented Jun 19, 2019

Can you add a snippet such as googleapis/google-cloud-python#8422 that does show how to override this?

@grant
Copy link
Contributor Author

grant commented Jun 19, 2019

@tswast I can't add a new snippet. That's not in scope of the sample I'm trying to standardize, fixing the attached bug.
I'm updating this snippet in a few languages.

I can change this PR to help fix the bug in some other way, but would like explicit instructions on how to do that.

@tswast
Copy link
Contributor

tswast commented Jun 20, 2019

Per the bug, if you aren't adding a new snippet (location autodetection is a new feature, after all), please add an explanation comment as we did in Java. googleapis/google-cloud-java#5475

@grant
Copy link
Contributor Author

grant commented Jun 20, 2019

Like the Java snippet, I added a note that the location is inferred here.

@grant grant merged commit 2e2ca1b into master Jun 20, 2019
@grant grant deleted the grant-116968956 branch June 20, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants