Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Spanner: pick up fixes to GAPIC generator. #6507

Closed
wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1.
synthtool > Replaced '# limitations under the License.\n\nimport google.api_core.grpc_helpers\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced 'from google.cloud.spanner_v1.proto import spanner_pb2_grpc\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced '(\\s+)return google.api_core.grpc_helpers.create_channel\\(\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1.
synthtool > Replaced "'google-cloud-spanner-admin-instance'" in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.instance_v1.proto' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py.
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* The instance is readable via the API, with all requested attributes
        but no allocated resources. Its state is `CREATING`., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* Cancelling the operation renders the instance immediately unreadable
        via the API., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* Billing for all successfully-allocated resources begins \(some types
        may have lower than the requested levels\)., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* The instance and \*all of its databases\* immediately and
        irrevocably disappear from the API. All data in the databases
        is permanently deleted., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
                  \* ``labels.env:dev`` --> The instance has the label \\"env\\" and the value of
                ::

                                       the label contains the string \\"dev\\"., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
                  \* ``name:howl labels.env:dev`` --> The instance's name contains \\"howl\\" and
                ::

                                                 it has the label \\"env\\" with its value
                                                 containing \\"dev\\"., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* For resource types for which a decrease in the instance's allocation
        has been requested, billing is based on the newly-requested level., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* Cancelling the operation sets its metadata's
        \[cancel_time\]\[google.spanner.admin.instance.v1.UpdateInstanceMetadata.cancel_time\], and begins
        restoring resources to their pre-request values. The operation
        is guaranteed to succeed at undoing all resource changes,
        after which point it terminates with a `CANCELLED` status., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* Reading the instance via the API continues to give the pre-request
        resource levels., maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py for pattern 
        \* Billing begins for all successfully-allocated resources \(some types
        may have lower than the requested levels\).
        \* All newly-reserved resources are available for serving the instance's
        tables., maybe replacement is not longer needed?
synthtool > Replaced '====*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '----*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '~~~~*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1.
synthtool > Replaced "'google-cloud-spanner-admin-database'" in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py.
synthtool > No replacements made in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py for pattern database ID must be enclosed in backticks \(`` `` ``\)., maybe replacement is not longer needed?
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added api: spanner Issues related to the Spanner API. codegen labels Nov 19, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated spanner to pick up changes in the API or client library generator. Spanner: pick up fixes to GAPIC generator. Nov 19, 2018
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these PRs:

Unfortunately, misses changes to one of the generated test files.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2018
@tseaver tseaver changed the title Spanner: pick up fixes to GAPIC generator. [DO NOT MERGE] Spanner: pick up fixes to GAPIC generator. Nov 19, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 19, 2018

Superseded by #6576.

tseaver added a commit that referenced this pull request Nov 19, 2018
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to *all* generated tests.

Removes now-spurious docstring fixups.

Closes #6507.
@tseaver tseaver deleted the autosynth-spanner branch November 19, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants