This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Remove pending deprecation spew from unit tests. #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'stacklevel=2' to each emitted 'PendingDeprecationWarning'. - Fix detection of non-default 'client_config' argument (make the default 'None', and assign in the body). - Replace deprecation-emitting 'channel=channel' arguments to client constructors with mocks of the 'create_channel' utility function. Closes #2389.
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
============================================
+ Coverage 86.72% 86.72% +<.01%
Complexity 5241 5241
============================================
Files 458 458
Lines 20867 20870 +3
Branches 2252 2252
============================================
+ Hits 18096 18099 +3
Misses 1968 1968
Partials 803 803
Continue to review full report at Codecov.
|
lukesneeringer
approved these changes
Nov 7, 2018
showcase/python/nox.py
Outdated
| @@ -36,7 +36,7 @@ def showcase(session, py): | |||
| session.virtualenv_dirname = 'showcase-' + py | |||
|
|
|||
| # Install all test dependencies, then install this package in-place. | |||
| session.install('pytest') | |||
| session.install('pytest', 'mock') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@lukesneeringer I'm not sure how to debug the |
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 8, 2018
In anticipation of landing googleapis/gapic-generator#2407.
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these `gapic-generator` PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
This was referenced Nov 14, 2018
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6500. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6498. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6496. Includes generated test changes. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 30, 2018
Includes fixes from these gapic-generator PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
busunkim96
pushed a commit
to googleapis/python-videointelligence
that referenced
this pull request
Dec 19, 2019
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-videointelligence
that referenced
this pull request
Dec 19, 2019
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Closes #6512.
busunkim96
pushed a commit
to googleapis/python-websecurityscanner
that referenced
this pull request
Jan 30, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6476.
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Jan 31, 2020
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
crwilcox
pushed a commit
to googleapis/python-bigtable
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6492.
busunkim96
pushed a commit
to googleapis/python-container
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Includes synth replacements to work around generated docstring issue: - googleapis/gapic-generator/issues/2449 Closes #6483.
crwilcox
pushed a commit
to googleapis/python-firestore
that referenced
this pull request
Jan 31, 2020
* Firestore: pick up fixes to GAPIC generator. Closes #6497. Includes changes to generated tests. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 * Fix overlong lines introduced in PR #6481.
crwilcox
pushed a commit
to googleapis/python-spanner
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to *all* generated tests. Removes now-spurious docstring fixups. Closes #6507.
busunkim96
pushed a commit
to googleapis/python-dlp
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
leahecole
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
Jan 31, 2020
In anticipation of landing googleapis/gapic-generator#2407.
crwilcox
pushed a commit
to googleapis/python-vision
that referenced
this pull request
Feb 1, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6475.
crwilcox
pushed a commit
to googleapis/python-trace
that referenced
this pull request
Feb 1, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Removes now-spurious docstring fixups. Closes #6511.
busunkim96
pushed a commit
to googleapis/python-tasks
that referenced
this pull request
Feb 4, 2020
In anticipation of landing googleapis/gapic-generator#2407.
plamut
pushed a commit
to googleapis/python-bigquery-datatransfer
that referenced
this pull request
Feb 5, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
plamut
pushed a commit
to googleapis/python-bigquery-storage
that referenced
this pull request
Feb 5, 2020
Includes fixes from these gapic-generator PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
plamut
pushed a commit
to googleapis/python-dataproc
that referenced
this pull request
Feb 5, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
plamut
pushed a commit
to googleapis/python-logging
that referenced
this pull request
Feb 5, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6474.
busunkim96
pushed a commit
to googleapis/python-oslogin
that referenced
this pull request
Feb 5, 2020
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-oslogin
that referenced
this pull request
Feb 5, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Closes #6502.
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Feb 5, 2020
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Feb 5, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
busunkim96
pushed a commit
to googleapis/python-iot
that referenced
this pull request
Feb 5, 2020
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-iot
that referenced
this pull request
Feb 5, 2020
Closes #6498. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396.
busunkim96
pushed a commit
to googleapis/python-language
that referenced
this pull request
Feb 6, 2020
Closes #6500. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
plamut
pushed a commit
to googleapis/python-error-reporting
that referenced
this pull request
Feb 6, 2020
Closes #6496. Includes generated test changes. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
crwilcox
pushed a commit
to googleapis/python-datastore
that referenced
this pull request
Feb 6, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
busunkim96
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Feb 7, 2020
In anticipation of landing googleapis/gapic-generator#2407.
busunkim96
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Feb 7, 2020
Includes fixes from these `gapic-generator` PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacklevel=2to each emittedPendingDeprecationWarning.client_configargument (make the defaultNone, and assign in the body).channel=channelarguments to client constructors with mocks of thecreate_channelutility function.Closes #2389.