Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after grpcio update #5333

Merged
merged 2 commits into from
May 16, 2018
Merged

Fix tests after grpcio update #5333

merged 2 commits into from
May 16, 2018

Conversation

crwilcox
Copy link
Contributor

grpcio updated their package and seem to have added a close method. This PR updates the stub.

@crwilcox crwilcox requested a review from lukesneeringer as a code owner May 16, 2018 17:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2018
@crwilcox crwilcox requested a review from theacodes May 16, 2018 17:43
@theacodes
Copy link
Contributor

We will need to cut a new release of api_core.

@tseaver tseaver mentioned this pull request May 16, 2018
Merged
@crwilcox crwilcox merged commit 3376f6e into googleapis:master May 16, 2018
@tseaver tseaver mentioned this pull request May 17, 2018
Merged
@crwilcox crwilcox deleted the fix/grpcio-update branch July 30, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @theacodes @googlebot