Grpcio pre system tests #5304
Grpcio pre system tests #5304
Conversation
Update documentation to have correct entity string repr
| @@ -93,6 +93,9 @@ def system(session, py): | |||
| # Set the virtualenv dirname. | |||
| session.virtualenv_dirname = 'sys-' + py | |||
|
|
|||
| # Use pre-release gRPC for system tests. | |||
| session.install('--pre', 'grpcio') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -86,6 +86,9 @@ def system(session, py): | |||
| # Set the virtualenv dirname. | |||
| session.virtualenv_dirname = 'sys-' + py | |||
|
|
|||
| # Use pre-release gRPC for system tests. | |||
| session.install('--pre', 'grpcio') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@crwilcox How long do we expect to need the pre-release version of |
|
@tseaver I assumed this was proactive on our part so that we could catch errors in gRPC that cause issues in the client libs before the release. I agree it would be good to get some clarification as to why we are adding this (ideally as comments in the code). |
|
@tswast I'm actually opposed to doing our normal CI against pre-releases of dependencies: we need more stability in our everyday runs, not less. It would be fine if we had an additional (maybe nightly?) "smoke test" for such things. |
|
I'd be on board with splitting risky / flakey / slow & only moderate value system tests into a nightly build. |
|
That sounds lovely, unfortunately, our current CI is working against us here. Let's defer that until we move to Kokoro. |
|
@crwilcox You merged this one without getting consensus about the tradeoffs of using prerelease dependencies. I will ask again: Is there a specifc issue addressed by a particular |
|
Note that #5333 (addressing https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/6613) is the kind of flakiness I'm talking about: we are now in a mode where we can't run against both the released and the unreleased |
No description provided.