Harden spanner system tests against stray databases #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Nov 9, 2017
spanner/tests/system/test_system.py
Outdated
| self.assertEqual(found, expected) | ||
| database_ids = [ | ||
| database.database_id | ||
| for database in Config.INSTANCE.list_databases()] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Because of quota, we are sharing the instance we use to test CRUD of databases: we therefore cannot rely on having only the expected databases present, as other tests may be running simultaneously, or may have failed in ways which left 'stray' databases in the instance.
066d8a5 to
8f20130
Compare
|
#4377 is blocking the run. The system tests pass locally. |
This was referenced Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of quota, we are sharing the instance we use to test CRUD of databases: we therefore cannot rely on having only the expected databases present, as other tests may be running simultaneously, or may have failed
in ways which left 'stray' databases in the instance.