Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spanner system tests: #4372

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Add spanner system tests: #4372

merged 1 commit into from
Nov 10, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 9, 2017

  • Write / read back null string.
  • Write / read back empty array of string.
  • Write / read back null array of string.
  • Write / read back array of string with mixed null / non-null values.

Toward #4364.

@tseaver tseaver added api: spanner Issues related to the Spanner API. testing labels Nov 9, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2017
@tseaver tseaver mentioned this pull request Nov 9, 2017
Closed
19 tasks
@tseaver
Add spanner system tests:
79922ca 
- Write / read back null string.
- Write / read back empty array of string.
- Write / read back null array of string.
- Write / read back array of string with mixed null / non-null values.

Toward #4364.
@tseaver tseaver force-pushed the 4364-spanner-systest-write-read-back-array-string branch from dcf20cd to 79922ca Compare November 9, 2017 21:52
@tseaver
Copy link
Contributor Author

tseaver commented Nov 9, 2017

Rebased to pick up hardening from merged #4374.

chemelnucfin
chemelnucfin approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@chemelnucfin chemelnucfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tseaver tseaver merged commit c353f2b into master Nov 10, 2017
@tseaver tseaver deleted the 4364-spanner-systest-write-read-back-array-string branch November 10, 2017 16:40
@tseaver tseaver mentioned this pull request Dec 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemelnucfin chemelnucfin chemelnucfin approved these changes

@dhermes dhermes Awaiting requested review from dhermes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @chemelnucfin @googlebot