Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair logging client 'list_*' methods. #1823

Merged
merged 1 commit into from
May 26, 2016
Merged

Repair logging client 'list_*' methods. #1823

merged 1 commit into from
May 26, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 26, 2016

Broken in #1820. Borked logging system tests pass with this patch.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: logging Issues related to the Cloud Logging API. labels May 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2016
@dhermes
Copy link
Contributor

dhermes commented May 26, 2016

LGTM

@tseaver tseaver merged commit d4ff022 into googleapis:master May 26, 2016
@tseaver tseaver deleted the 1820-logging-repair_client_list_methods branch May 26, 2016 16:33
@dhermes dhermes mentioned this pull request Jun 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot