Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor API-related calls into service-specific helpers. #1820

Merged
merged 4 commits into from
May 25, 2016
Merged

Factor API-related calls into service-specific helpers. #1820

merged 4 commits into from
May 25, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 24, 2016

Modeled on the pubsub changes in #1700 and #1736.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label May 24, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2016
dhermes
dhermes reviewed May 25, 2016
View reviewed changes
gcloud/logging/client.py
def logging_api(self):
"""Helper for logging-related API calls."""
if self._logging_api is None:
self._logging_api = _LoggingAPI(self.connection)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented May 25, 2016

It's a lot to digest, but nothing glaring. Anything in particular I should focus on?

@tseaver
Copy link
Contributor Author

tseaver commented May 25, 2016

It's a lot to digest, but nothing glaring. Anything in particular I should focus on?

This one is a pretty mechanical transform, following the earlier pubsub pattern. Given CI testing for coverage and lint, he "usual suspects" would be copy-pasta errors, particularly docstrings,

@tseaver tseaver mentioned this pull request May 25, 2016
Closed
dhermes
dhermes reviewed May 25, 2016
View reviewed changes
gcloud/logging/client.py

@property
def metrics_api(self):
"""Helper for logging-related API calls."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented May 25, 2016

Did a docs pass and made a few comments. Everything (save for those few comments) LGTM.

@tseaver tseaver merged commit 88daa08 into googleapis:master May 25, 2016
@tseaver tseaver deleted the logging-grpc_prep branch May 25, 2016 23:19
@tseaver tseaver mentioned this pull request May 26, 2016
Merged
@dhermes dhermes mentioned this pull request Jun 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot