Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds script for git migration. #10882
feat: adds script for git migration. #10882
Changes from all commits
61a3bb6
2c1e1e4
fcb0211
39432b1
2096df7
e336cd3
a3694e4
57e96dc
c7c0d48
a303e0f
5c57e45
997909f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per offline chat, sounds like we also need to
mkdir -p owl-bot-staging/${DISTRIBUTION_NAME}
after validation and before creating the PR.Which means maybe we do the
jq
extract into${DISTRIBUTION_NAME}
and then setTARGET_PATH="packages/${DISTRIBUTION_NAME}"
above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per correction in chat, we'll need to
although it's not clear this is sufficient to make the migrated repo pass pre-submits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, added owl-bot-staging. But, we should add any necessary fixes, if needed, in follow-up PRs.