-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds script for git migration. #10882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One relatively minor comment.
But I do think we want the other open comment, deriving ${ARTIFACT_NAME}
from the split repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only issue is about the commented-out gh
command. Could you address that before merging?
$EXIT 1 | ||
fi | ||
|
||
pushd "${TARGET_REPO}" # To target repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per offline chat, sounds like we also need to mkdir -p owl-bot-staging/${DISTRIBUTION_NAME}
after validation and before creating the PR.
Which means maybe we do the jq
extract into ${DISTRIBUTION_NAME}
and then set TARGET_PATH="packages/${DISTRIBUTION_NAME}"
above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per correction in chat, we'll need to
mkdir -p owl-bot-staging/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}
touch owl-bot-staging/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}.txt
git add owl-bot-staging
git commit -m "Trigger owlbot post-processor"
although it's not clear this is sufficient to make the migrated repo pass pre-submits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, added owl-bot-staging. But, we should add any necessary fixes, if needed, in follow-up PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-trivial comment about making the title have a conventional commit format.
Script that migrates Git history of a split repo to google-cloud-python.
It copies Git history from source repo (i.e. "split repo") to target repo (i.e.
google-cloud-python
). Then, creates a pull request in target repo.