Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Language v1 #2747

Closed
bjwatson opened this issue Nov 17, 2016 · 8 comments
Closed

Update to Language v1 #2747

bjwatson opened this issue Nov 17, 2016 · 8 comments
Assignees

Comments

@bjwatson
Copy link

What

Update the hand-written code to Language v1, which was publicly announced yesterday (11/15). The new GAPIC code is in a PR, which will be published to PyPI as soon as its approved.

Why

Language v1beta1 has been replaced by v1 as of Tuesday 11/15. It has some additional features we want to support.

This should be done soon, so that we can update the public documentation and samples to reference the google-cloud-language library.

@jmdobry
Copy link
Contributor

jmdobry commented Nov 17, 2016

Friendly 🐶 notification, this is blocking GoogleCloudPlatform/python-docs-samples#668

@bjwatson
Copy link
Author

Thanks for the heads up @jmdobry. Once I get LGTM on googleapis/api-client-staging#106, I'll publish Python GAPIC for Language v1, and then @dhermes can take a look at what's needed in the hand-written code.

@dhermes
Copy link
Contributor

dhermes commented Nov 18, 2016

@bjwatson FWIW the current implementation is JSON-over-HTTP only, so an update isn't blocked on the GAPIC release. (To check if a given API package is using GAPIC yet, just check the deps.)

@bjwatson
Copy link
Author

Ok, thanks @dhermes. At least you'll have it when you add the gRPC path. :)

@tseaver tseaver added release blocking Required feature/issue must be fixed prior to next release. and removed release blocking Required feature/issue must be fixed prior to next release. labels Nov 21, 2016
@gguuss
Copy link
Contributor

gguuss commented Nov 28, 2016

Friendly ping, we're still waiting on this.

@jmdobry
Copy link
Contributor

jmdobry commented Nov 29, 2016

To switch to NL V1 does google-cloud-python also need to switch to using the GAPIC code, or can just the JSON-over-HTTP stuff get updated?

@dhermes
Copy link
Contributor

dhermes commented Nov 29, 2016

Just the JSON-over-HTTP stuff can get updated. What is the delta between the old and new versions? Is it as simple as changing one line?

@jmdobry
Copy link
Contributor

jmdobry commented Nov 29, 2016

Seems there was at least one breaking change (from the google-cloud-node PR updating to NL V1):

  • New rcp AnalyzeSyntax in the form of document#detectSyntax
  • Sentences can now contain sentiments
  • sentiment.polarity was renamed to sentiment.score
  • partOfSpeech received 11 new attributes
  • English, Japanese and Spanish now supported for all features.

See googleapis/google-cloud-node#1783

@dhermes dhermes closed this as completed in 4219e3e Dec 3, 2016
dhermes added a commit that referenced this issue Dec 3, 2016
Switch NL from v1beta1 to v1. Fixes #2747.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
atulep pushed a commit that referenced this issue Apr 6, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
atulep pushed a commit that referenced this issue Apr 18, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jul 6, 2023
parthea pushed a commit that referenced this issue Jul 6, 2023
Switch NL from v1beta1 to v1. Fixes #2747.
parthea pushed a commit that referenced this issue Oct 22, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants