-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Language v1 #2747
Comments
Friendly 🐶 notification, this is blocking GoogleCloudPlatform/python-docs-samples#668 |
Thanks for the heads up @jmdobry. Once I get LGTM on googleapis/api-client-staging#106, I'll publish Python GAPIC for Language v1, and then @dhermes can take a look at what's needed in the hand-written code. |
@bjwatson FWIW the current implementation is JSON-over-HTTP only, so an update isn't blocked on the GAPIC release. (To check if a given |
Ok, thanks @dhermes. At least you'll have it when you add the gRPC path. :) |
Friendly ping, we're still waiting on this. |
To switch to NL V1 does google-cloud-python also need to switch to using the GAPIC code, or can just the JSON-over-HTTP stuff get updated? |
Just the JSON-over-HTTP stuff can get updated. What is the delta between the old and new versions? Is it as simple as changing one line? |
Seems there was at least one breaking change (from the google-cloud-node PR updating to NL V1):
|
Switch NL from v1beta1 to v1. Fixes #2747.
Switch NL from v1beta1 to v1. Fixes googleapis#2747.
…orm/python-docs-samples#2747) * speech: fixing flaky auto punctuation test * Fixing beta test for auto punctuation Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
…orm/python-docs-samples#2747) * speech: fixing flaky auto punctuation test * Fixing beta test for auto punctuation Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
…orm/python-docs-samples#2747) * speech: fixing flaky auto punctuation test * Fixing beta test for auto punctuation Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Switch NL from v1beta1 to v1. Fixes #2747.
…orm/python-docs-samples#2747) * speech: fixing flaky auto punctuation test * Fixing beta test for auto punctuation Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
What
Update the hand-written code to Language v1, which was publicly announced yesterday (11/15). The new GAPIC code is in a PR, which will be published to PyPI as soon as its approved.
Why
Language v1beta1 has been replaced by v1 as of Tuesday 11/15. It has some additional features we want to support.
This should be done soon, so that we can update the public documentation and samples to reference the
google-cloud-language
library.The text was updated successfully, but these errors were encountered: